Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove postcss loader from webpack config #7273

Merged
merged 1 commit into from
Sep 30, 2022
Merged

Remove postcss loader from webpack config #7273

merged 1 commit into from
Sep 30, 2022

Conversation

thelovekesh
Copy link
Collaborator

@thelovekesh thelovekesh commented Sep 30, 2022 •
edited
Loading

Summary

This PR removes explicitly added postcss-loader as @wordpress/scripts now uses PostCSS 8 in the webpack config.

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@thelovekesh thelovekesh self-assigned this Sep 30, 2022
@github-actions
Copy link
Contributor

Plugin builds for 0c962d4 are ready 🛎️!

@thelovekesh thelovekesh changed the title Remove module overriding for explicitly adding postcss loader Remove postcss loader from webpack config Sep 30, 2022
@westonruter westonruter added this to the v2.3.1 milestone Sep 30, 2022
@westonruter westonruter merged commit 7048475 into develop Sep 30, 2022
@westonruter westonruter deleted the update/webpack-config branch September 30, 2022 20:25
@westonruter westonruter modified the milestones: v2.3.1, v2.4 Jan 26, 2023
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

@delawski delawski Awaiting requested review from delawski

Assignees

@thelovekesh thelovekesh

Labels
Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
Milestone
v2.4
Development

Successfully merging this pull request may close these issues.
2 participants
@thelovekesh @westonruter