Automatically mark GA4 scripts as being PX-verified #7290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plugin builds for aeacc33 are ready 🛎️!
|
westonruter
requested changes
Oct 20, 2022
…tizers Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
…base transaction after each test run
thelovekesh
commented
Oct 21, 2022
westonruter
reviewed
Oct 21, 2022
westonruter
reviewed
Oct 21, 2022
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
westonruter
reviewed
Oct 25, 2022
westonruter
reviewed
Oct 25, 2022
westonruter
reviewed
Oct 25, 2022
westonruter
reviewed
Oct 25, 2022
westonruter
reviewed
Oct 25, 2022
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
thelovekesh
force-pushed
the
add/GA4-scripts-sanitizer
branch
from
9f945a3
to
6bec836
Compare
thelovekesh
commented
Oct 26, 2022
westonruter
reviewed
Oct 27, 2022
westonruter
approved these changes
Oct 27, 2022
westonruter
added
the
Changelogged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a sanitizer(
AMP_GTag_Script_Sanitizer) for GA4 scripts, marking GA4 scripts as px verified and hence users can use the latest GA while AMP implements it.Apart from adding sanitizer, this PR update Option interface includes options used in Sandboxing service.
Fixes #7289
Checklist