Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update is_frontend_url() to verify passed url path with home_url() #7330

Merged
merged 10 commits into from
Nov 10, 2022
Merged

Update is_frontend_url() to verify passed url path with home_url() #7330

merged 10 commits into from
Nov 10, 2022

Conversation

thelovekesh
Copy link
Collaborator

@thelovekesh thelovekesh commented Nov 9, 2022 •
edited
Loading

Summary

Apart from fixing #7329 this PR also fixes the following things:

  • Errors reported by the new PHPStan version(v1.9.2).
  • Failing E2E tests. These errors were caused due to missing twentytwenty theme from the WP distribution.
  • Failing PHPUnit tests due to the new Gutenberg release.

Fixes #7329

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@thelovekesh thelovekesh self-assigned this Nov 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022 •
edited
Loading

Plugin builds for 2c39c36 are ready 🛎️!

westonruter
westonruter requested changes Nov 9, 2022
View reviewed changes
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you also please add tests to ensure this is working as expected?

@thelovekesh
Copy link
Collaborator Author

@westonruter This PR has been updated to fix all static analysis, PHPUnit, and e2e test issues. I will revert related changes from other PRs as they might get delayed in merging and failing tests cause some confusion while reviewing the PRs.

@westonruter westonruter added this to the v2.3.1 milestone Nov 10, 2022
westonruter
westonruter approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@westonruter westonruter merged commit 55ac6fc into develop Nov 10, 2022
@westonruter westonruter deleted the add/path-check-in-frontend-url branch November 10, 2022 16:18
@westonruter westonruter mentioned this pull request Nov 10, 2022
Closed
@westonruter westonruter modified the milestones: v2.3.1, v2.4 Jan 26, 2023
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

Assignees

@thelovekesh thelovekesh

Labels
Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
Milestone
v2.4
Development

Successfully merging this pull request may close these issues.

wp_nav_menu suffix in Custom links to remote websites
2 participants
@thelovekesh @westonruter