Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

ampproject / amp-wp Public

Notifications You must be signed in to change notification settings
Fork 384
Star 1.8k

Code
Issues 19
Pull requests 36
Discussions
Actions
Projects 1
Wiki
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Discussions
Actions
Projects
Wiki
Security
Insights

Add guard to avoid fatal error in case logo height/width is zero#7429

Merged

westonruter merged 6 commits intodevelopampproject/amp-wp:developfrom fix/fatal-error-when-logo-height-is-zeroampproject/amp-wp:fix/fatal-error-when-logo-height-is-zeroCopy head branch name to clipboard

Jan 30, 2023

+84-1

Conversation Commits6 (6)Checks Files changed

Commits

Commits on Jan 27, 2023

Add guard to avoid fatal error in case logo height/width is zero
thelovekesh
committed
Update logic to bail only if logo height is zero
thelovekesh
committed
Add test cases to verify guards when logo height is zero
thelovekesh
committed

Commits on Jan 28, 2023

Remove vague ternary operator

thelovekesh
and
westonruter
authored
Update condition to bail early in case of image with zero width

thelovekesh
and
westonruter
authored
Update test cases to account zero as image width
thelovekesh
committed

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.