Add guard to avoid type errors due to null validation sources #7500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plugin builds for 325d8f6 are ready 🛎️!
|
westonruter
reviewed
Mar 22, 2023
assets/src/components/site-scan-results/site-scan-sources-detail.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Weston Ruter <westonruter@google.com>
westonruter
approved these changes
Mar 22, 2023
|
QA Passed ✅ Before, clicking on the site scan details would crash the AMP Settings screen. After applying this update, site scan details are displayed as intended and are not resulting in any fatal or console errors.
|
westonruter
added
the
Changelogged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously discovered in #7380 there were some type errors due to null validation sources in SiteScan. This PR aims to fix the same issue in the
<SiteScanSourcesDetail />component.Screencast
bbd99734927244e48bced2799736df7a-1679500487677.mp4
Checklist