Revert custom GB 16.3 installation steps and add WP_DEBUG support in local-env #7602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plugin builds for 72656b2 are ready 🛎️!
|
thelovekesh
force-pushed
the
remove/custom-gb-plugin-installation
branch
from
8e6fded
to
dcff3ca
Compare
westonruter
reviewed
Aug 31, 2023
There was a problem hiding this comment.
How did you know to update this?
There was a problem hiding this comment.
These are the mappings for the plugin services factory, which should be the same as AmpWpPlugin::SERVICES and enable auto-completion for SERVICES::get() Since some of the services were misspelled and some were missing from the PHPStorm meta-file, I added them.
Ref: https://www.jetbrains.com/help/phpstorm/ide-advanced-metadata.html#passing-a-string-literal
|
The E2E tests seem to be timing out. I just tried to re-run the failed job but got the same result. |
thelovekesh
force-pushed
the
remove/custom-gb-plugin-installation
branch
from
842ddd2
to
9a6f0a0
Compare
westonruter
reviewed
Aug 31, 2023
| @@ -50,7 +50,7 @@ describe('AMP developer tools settings', () => { | |||
| 'page=amp-options', | |||
| 'other-settings' | |||
| ); | |||
| }); | |||
| }, 400000); | |||
There was a problem hiding this comment.
Yes, by default we are using 300 seconds.
westonruter
added
the
Changelogged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In order to pass the E2E test cases, we made some temporary adjustments in #7591. The issues we had back then have been resolved upstream. This PR reverts those temporary modifications.
Checklist