Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Issue #843: Validate Gutenberg blocks for AMP compliance #902

Closed
wants to merge 2 commits into from

Commits on Jan 25, 2018

  1. Issue #843: Validate Gutenberg blocks for AMP compliance.

    In wp-admin/post.php, load a script.
    This overwrites the edit() function of registered blocks.
    The new function validates the block's content.
    And conditionally displays a notice.
    @todo: consider not using this for all blocks.
    Some blocks are valid once the back-end sanitizer alters them.
    Like the 'Audio' block.
    This simply uses the save() function of the block to get the markup.
    Ryan Kienstra committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    f530a9a View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2018

  1. Issue #843: AMP validation of the front page from the editor.

    On saving a post in post.php, make request to the permalink for the post.
    And validate that for AMP compatibility.
    This applies to the 'classic' editor, not AMP.
    But refactoring validatePage() would allow it to be used on Gutenberg.
    Ryan Kienstra committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    1be29b4 View commit details
    Browse the repository at this point in the history