-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sanitization reporting #912
Merged
Merged
Changes from 38 commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
0a44284
Add initial callback for listening for element/attribute removal in w…
westonruter e9f394a
Issue #843: Tracking for removed nodes and attributes.
d7104b8
Issue #843: Correct a failed Travis build by excluding a PHPCS rule.
616262f
Issue #843: Add a method to process markup for AMP validtity.
4714062
Issue #843: Track removed iframes in a helper method.
e209005
Issue #843: Initial registration of the REST endpoint for validation.
aed76c6
Issue #864: Support <amp-carousel> in 'Gallery' widget.
30c666f
Issue #843: Report removed attributes and nodes in a histogram.
76b0f17
Revert "Issue #864: Support <amp-carousel> in 'Gallery' widget."
0b7c3fc
Issue #843: Align equals signs vertically.
71744e5
Issue #843: Prepare to add headers to frontend GET requests.
da408bf
Issue #843: Align an equals sign to correct the failed Travis build.
ab3909a
Issue #864: Validation data in the response header.
90090b0
Issue #864: Remove an extra conditional, nest the 'mutation_callback.'
83dac87
Issue #864: Rename function to finish_output_buffering().
70521ef
Issue #843: Remove the extra variabl in the @return tag.
cc4fe85
Issue #843: Add processed markup to REST API response.
0b6a4ee
Issue #843: Output the 'processed_markup' at the bottom of the response.
db49a33
Issue #843: Merge in 'develop' branch and resolve conflicts.
c92bee4
Issue #843: Apply validation to post update on wp-admin/post.php.
6b5593b
Issue #843: Verify the nonce before validating on 'save_post'.
a168a5c
Issue #843: Sanitize $_GET value in addition to the 'ignore' comment.
a52ae05
Issue #843: Correct Travis error by changing error text.
0472a33
Issue #843: Report node removal in the rest of the sanitizers.
6d2350f
Merge branch 'develop' of https://github.com/Automattic/amp-wp into a…
westonruter 3de38b8
Issue #843: Call the 'mutation_callback' for more attribute removals.
46e7084
Issue #843: Merge in develop, resolve conflicts.
972ac2c
Issue #843: Merge in develop again, resolve conflicts.
d2ab9ee
Issue #843: Rename test to 'get_buffer' instead of 'prepare_response'.
cb0cfc9
Issue #843: Fix an issue in the error message.
084acaa
Issue #843: Revert renaming of methods, adjust unit tests.
13ab280
Issue #843: Remove special characters, update documentation.
f996673
Issue #843: Change @const to @var for constants.
f8aeca8
Issue #843: Rename class to 'AMP_Validation_Utils'
69317b8
Issue #843; Use constants instead of string literals.
583a6bc
Issue #843: Add nonce verification for the editor message.
cd910ff
Issue #843: Align comments in addition to variable names.
a6d071a
List the AMP-invalid elements and attributes that have been saved
westonruter b40729b
Only report mutations when node/attribute is removed due to invalidity
westonruter 9954c11
Improve naming of callback and removal methods
westonruter 15d9186
Remove add_header until use case is confirmed
westonruter bb7a175
Skip reporting removal of iframe's former parent node
westonruter 29caa8a
Skip sanitization reporting when saving post that doesn't support AMP
westonruter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to remove thus until we have it being utilized in the plugin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, that's fine.