Update sanitization reporting #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DOMElement or DOMAttr
westonruter
force-pushed
the
update/sanitization-reporting
branch
from
0e47520
to
fd56169
Compare
kienstra
reviewed
Feb 13, 2018
There was a problem hiding this comment.
Commits Approved
Hi @westonruter,
Thanks a lot for your commits here. It's nice how this gets the count of elements and attributes in track_removed(), instead of every time one is added.
I'll continue by applying the 2 checkbox points you made.
kienstra
approved these changes
Feb 13, 2018
added 3 commits
February 13, 2018 13:31
Before, this was on the 'save_post' action. But as Weston mentioned, this could be in one place, and this removes the need for a nonce. Also, remove the function is_authorized(). This checked for a nonce. Replace this with the existing has_cap().
Because 'wpautop' runs on 'the_content', process_markup() showed errors from removing <p> tags. For example, it created this markup: <p><script async src=https://example.com/script></script></p> It seemed to have removed the <p> tag, As it contained a disallowed element. But it's not needed to report that the <p> is removed. So remove 'wpautop' as a callback for 'the_content.' Gutenberg also does this, unless the post has no block. @see gutenberg_wpautop().
Instead of wrapping the 'invalid_callback' in this, simply exist process_markup(). If that callback isn't added, there's no need for the rest of the function.
|
The fix to embeds here should prevent this from happening on #954:
|
westonruter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #912 for #843.
save_postaction in favor of doing it inline when loading the edit post screen.This PR could also include parts from #842 if we want.