draft: move all build constants for bundlers instead of babel #34277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samouri
changed the title
samouri
changed the title
samouri
commented
May 7, 2021
| // Therefore, all conditions set by ESM will also hold for SxG. | ||
| // However, we will also need to introduce a separate IS_SxG flag | ||
| // for conditions only true for SxG. | ||
| const replacements = [ |
There was a problem hiding this comment.
self-review: figure out the rest of the experiments
rcebulko
reviewed
May 11, 2021
| * Build Constants -- see build-system/build-constants.js for definition. | ||
| */ | ||
| /** @define {boolean} */ | ||
| var IS_FORTESTING = false; |
There was a problem hiding this comment.
Let's maybe split these out and stick em in something like compiler-constants.extern.js or something similar
There was a problem hiding this comment.
if this ever works...sure
There was a problem hiding this comment.
For now I've extracted the "combine all into one" element into: #34327
|
Closing because closure compiler does not support replacements within esm :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
We have a number of build-time constants that are all replaced by babel. Bundlers/compilers are actually a more natural time to perform this substitution. In fact, both
esbuildandclosuresupport it out of the box.