build: fix z-index #35106
Merged
build: fix z-index #35106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caroqliu
reviewed
Jul 1, 2021
There was a problem hiding this comment.
Should we have to include these for files that don't exist permanently in the repo? The ones added in this PR are built only for the npm publishing step. FYI @estherkim
|
See this check that is failing: https://app.circleci.com/pipelines/github/ampproject/amphtml/12352/workflows/f6450e19-40c7-4955-9a49-e1eebc0081cc/jobs/197521/parallel-runs/0/steps/0-111 Should we modify the z-index check to ignore anything in |
|
@samouri: Yes, we should ignore |
|
Here: amphtml/build-system/tasks/get-zindex/index.js Lines 208 to 212 in a7fec79 getZindexChainsInJs([
'{3p,src,extensions}/**/*.js',
+ '!**/dist/**/*.js',
'!extensions/**/test/**/*.js',
'!extensions/**/storybook/**/*.js',
]), |
alanorozco
approved these changes
Jul 1, 2021
caroqliu
approved these changes
Jul 1, 2021
kristoferbaxter
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
I created this PR via running
amp get-zindex --fix.I do not know why this was able to get out of sync.