performance-impl: start tracking lcp element #35123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samouri
force-pushed
the
perf-lcp-type
branch
from
2cacdf5 to
ed5e04e
Compare
|
Hey @jridgewell! These files were changed: |
jridgewell
approved these changes
Sep 17, 2021
Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
This reverts commit 8cb0f4a.
jridgewell
reviewed
Sep 17, 2021
jridgewell
approved these changes
Sep 17, 2021
Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
jridgewell
approved these changes
Sep 18, 2021
yotam-g
pushed a commit
to yotam-g/amphtml
that referenced
this pull request
Sep 22, 2021
* performance-impl: start tracking lcp element * tagName --> nodeName * include video * Update src/service/performance-impl.js Co-authored-by: Justin Ridgewell <justin@ridgewell.name> * Revert "Update src/service/performance-impl.js" This reverts commit 8cb0f4a. * Update src/service/performance-impl.js Co-authored-by: Justin Ridgewell <justin@ridgewell.name> Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
Creates a new csi beacon
lcpt(Largest Contentful Paint Type) for tracking which type of element caused the LCP.