🐛 fix build-constant isForTesting #35335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samouri
requested review from
rcebulko and
calebcordry
and removed request for
rsimha
calebcordry
reviewed
Jul 21, 2021
| @@ -18,7 +18,7 @@ const {VERSION} = require('./internal-version'); | |||
|
|
|||
| const testTasks = ['e2e', 'integration', 'visual-diff', 'unit', 'check-types']; | |||
| const isTestTask = testTasks.some((task) => argv._.includes(task)); | |||
| const isForTesting = argv.fortesting || isTestTask; | |||
| const isForTesting = argv.fortesting || !argv._.includes('dist'); | |||
There was a problem hiding this comment.
I'm out of my depth here but will this set getMode().localDev to true or getMode().test to true or both?
There was a problem hiding this comment.
It will allow getMode().localDev to be true. Without fortesting==true, the check early exits.
The naming of the variables is really not helping here.
I think if we flipped the conditions and renamed the variable to IS_FOR_PRODUCTION it would make much more sense.
There was a problem hiding this comment.
Seeing if it makes it more clear here: #35336
There was a problem hiding this comment.
Nice, I think the renaming helps. Thanks Jake.
calebcordry
reviewed
Jul 21, 2021
calebcordry
approved these changes
Jul 21, 2021
rcebulko
approved these changes
Jul 21, 2021
rsimha
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
Fixes #35325
I created a bug in local development when merging #34327.
I had assumed
isForTestingcorresponded to when the flag--fortestingwas passed, but really the value should always be true unlessamp distis used without the fortesting flag.cc @calebcordry