Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow changing the drain property in the receiver #14

Merged
merged 1 commit into from
Oct 22, 2018

Conversation

jfromaniello
Copy link
Contributor

Rhea supports changing the drain property to true as shown in this example:

https://github.com/amqp/rhea/blob/master/examples/drain.js#L37

@amarzavery
Copy link
Collaborator

Thanks for the PR. Can you let me know how do you plan to use the drain property? Some context would help improve my knowledge as well :)

@amarzavery amarzavery merged commit 209d5a5 into amqp:master Oct 22, 2018
@amarzavery
Copy link
Collaborator

0.1.8 version of rhea-promise has been published to npm.

@jfromaniello
Copy link
Contributor Author

I was trying to follow this example:
https://github.com/amqp/rhea/blob/master/examples/drain.js

To be able to subscribe to the drain event. To be honest I am not entirely sure if this is what I want.

I've a receiver, receiving and processing jobs. On SIGTERM I want the receiver to stop receiving new messages and when it finish processing what it has then, close the connection and terminate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants