Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in amundsen-databuilder setup command: 'extras_require' must be a dictionary whose values are strings or lists of strings containing valid project/version requirement specifiersBug Report #1447

Closed
Katemeva opened this issue Aug 18, 2021 · 8 comments

Comments

@Katemeva
Copy link

Katemeva commented Aug 18, 2021

'extras_require' must be a dictionary

I am with the quick start, and when running the setup.py I get this error:
error in amundsen-databuilder setup command: 'extras_require' must be a dictionary whose values are strings or lists of strings containing valid project/version requirement specifiers

has this happend to somebody?

I am using docker in windows and python 3.7
Capture

I haven't manipulated the setup.py
image

@boring-cyborg
Copy link

boring-cyborg bot commented Aug 18, 2021

Thanks for opening your first issue here!

@stale
Copy link

stale bot commented Sep 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Sep 2, 2021
@Marcel-Jan
Copy link

I had the same issue. So I've edited this extras_require dictionary. Turns out it does run without error when you remove all_deps and requirements_dev. So that's where the problem seems to be. Not sure what the effect is of removing them.

@stale stale bot removed the stale label Sep 20, 2021
@matthiaspchan
Copy link

if you trace it through, looks like the requirements-dev.txt in the databuilder folder is trying to point to the parent folder for the requirements, but the python script is loading in that text as the requirements instead. Probably needs a slight tweak...

For anyone needing a fix, what worked for me was to just copy the contents out of requirements-dev.txt in the amundsen folder and paste it into the body (replacing) the requirements-dev.txt in the amundsen\databuilder folder

@stale
Copy link

stale bot commented Oct 5, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Oct 5, 2021
@stale
Copy link

stale bot commented Oct 27, 2021

This issue has been automatically closed for inactivity. If you still wish to make these changes, please open a new pull request or reopen this one.

@stale stale bot closed this as completed Oct 27, 2021
@IanHopkinson
Copy link

IanHopkinson commented Feb 2, 2022

This happened to me too. As @matthiaspchan says the fix is to copy the content of the requirements-dev.txt in the amundsen folder into the contents of the copy in the databuilder directory

I suspect the root cause of this issue is that at some point someone used symlinks to ensure the various copies of the requirements-dev.txt file stayed in sync which worked on their machine but does not survive a roundtrip to GitHub. It may be relevant that I am using Git Bash on a Windows 10 machine (so the symlink issue may lie there)

@christofur
Copy link

Looking at: https://github.com/amundsen-io/amundsen/blob/main/Dockerfile.frontend.local#L24

Isn't the issue that, we wipe out requirements-dev.txt and requirements-common.txt with the dummy versions from node-stage?

To me, the fix would be to move COPY --from=node-stage /app /app to before line 21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants