docs: Update docs for Windows workaround to solve databuilder extras_require error. #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations on your first Pull Request and welcome to Amundsen community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/amundsen-io/amundsen/blob/main/CONTRIBUTING.md) |
alanmcruickshank
force-pushed
the
ac/windows_docs
branch
from
b5c05bc to
950290f
Compare
Signed-off-by: Alan <alanmcruickshank@gmail.com>
alanmcruickshank
force-pushed
the
ac/windows_docs
branch
from
950290f to
7ad5892
Compare
feng-tao
approved these changes
May 17, 2022
|
Awesome work, congrats on your first merged pull request! |
hansadriaans
pushed a commit
to DataChefHQ/amundsen
that referenced
this pull request
Jun 30, 2022
Signed-off-by: Alan <alanmcruickshank@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
An
extras_requirebug is documented in #1650 and #1447. Both suggest the same workaround and I only found this after trying to fix the bug myself. This adds an explicit note to the installation guide to point windows users to that workaround.This is my first PR to the project, so if there are docs style guides which I'm unaware of, I'm very happy to re-draft. 😄
CheckList
Make sure you have checked all steps below to ensure a timely review.