Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Postgres extractor example #1466

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

delwaterman
Copy link
Contributor

fix #1465

Summary of Changes

Add entity type to elastic search job

Tests

No tests needed for example

Documentation

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

@delwaterman delwaterman requested a review from a team as a code owner August 31, 2021 16:12
@boring-cyborg boring-cyborg bot added the area:databuilder From databuilder folder label Aug 31, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 31, 2021

Congratulations on your first Pull Request and welcome to Amundsen community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/amundsen-io/amundsen/blob/main/CONTRIBUTING.md)

@delwaterman delwaterman changed the title Fix Postgres extractor example fix:Postgres extractor example Aug 31, 2021
Signed-off-by: Orion Delwaterman <delwaterman@gmail.com>
@delwaterman delwaterman changed the title fix:Postgres extractor example fix: Postgres extractor example Aug 31, 2021
@feng-tao feng-tao merged commit 6ae2548 into amundsen-io:main Aug 31, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 31, 2021

Awesome work, congrats on your first merged pull request!

@delwaterman delwaterman deleted the fix-postgres-example branch August 31, 2021 18:05
ozandogrultan pushed a commit to deliveryhero/amundsen that referenced this pull request Apr 28, 2022
Signed-off-by: Orion Delwaterman <delwaterman@gmail.com>
Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
zacr pushed a commit to SaltIO/amundsen that referenced this pull request May 13, 2022
Signed-off-by: Orion Delwaterman <delwaterman@gmail.com>
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this pull request Jun 30, 2022
Signed-off-by: Orion Delwaterman <delwaterman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:databuilder From databuilder folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sample Postgres Loader does not create views
2 participants