-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add profile url to user model in databuilder and metadata services #1524
Merged
allisonsuarez
merged 5 commits into
amundsen-io:main
from
kristenarmes:add-profile-url-to-user-model
Oct 11, 2021
Merged
feat: Add profile url to user model in databuilder and metadata services #1524
allisonsuarez
merged 5 commits into
amundsen-io:main
from
kristenarmes:add-profile-url-to-user-model
Oct 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kristen Armes <karmes@lyft.com>
Signed-off-by: Kristen Armes <karmes@lyft.com>
boring-cyborg
bot
added
area:databuilder
From databuilder folder
area:metadata
From the metadata folder
category:api
labels
Oct 8, 2021
Signed-off-by: Kristen Armes <karmes@lyft.com>
Signed-off-by: Kristen Armes <karmes@lyft.com>
kristenarmes
requested review from
allisonsuarez,
bolkedebruin,
dechoma,
dkunitsk,
dorianj,
feng-tao,
jinhyukchang,
mgorsk1,
sewardgw,
verdan,
youngyjd and
a team
as code owners
October 8, 2021 20:40
dkunitsk
approved these changes
Oct 11, 2021
Signed-off-by: Kristen Armes <karmes@lyft.com>
amommendes
pushed a commit
to amommendes/amundsen
that referenced
this pull request
Jan 21, 2022
…ces (amundsen-io#1524) * Adding profile_url field to user model Signed-off-by: Kristen Armes <karmes@lyft.com> * Adding profile_url in more spots for consistency Signed-off-by: Kristen Armes <karmes@lyft.com> * Linting and adding new amundsenrds version to metadata setup.py Signed-off-by: Kristen Armes <karmes@lyft.com> * Fixing test Signed-off-by: Kristen Armes <karmes@lyft.com> * Bumping databuilder version Signed-off-by: Kristen Armes <karmes@lyft.com> Signed-off-by: Amom Mendes <amommendes@hotmail.com>
ozandogrultan
pushed a commit
to deliveryhero/amundsen
that referenced
this pull request
Apr 28, 2022
…ces (amundsen-io#1524) * Adding profile_url field to user model Signed-off-by: Kristen Armes <karmes@lyft.com> * Adding profile_url in more spots for consistency Signed-off-by: Kristen Armes <karmes@lyft.com> * Linting and adding new amundsenrds version to metadata setup.py Signed-off-by: Kristen Armes <karmes@lyft.com> * Fixing test Signed-off-by: Kristen Armes <karmes@lyft.com> * Bumping databuilder version Signed-off-by: Kristen Armes <karmes@lyft.com> Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
zacr
pushed a commit
to SaltIO/amundsen
that referenced
this pull request
May 13, 2022
…ces (amundsen-io#1524) * Adding profile_url field to user model Signed-off-by: Kristen Armes <karmes@lyft.com> * Adding profile_url in more spots for consistency Signed-off-by: Kristen Armes <karmes@lyft.com> * Linting and adding new amundsenrds version to metadata setup.py Signed-off-by: Kristen Armes <karmes@lyft.com> * Fixing test Signed-off-by: Kristen Armes <karmes@lyft.com> * Bumping databuilder version Signed-off-by: Kristen Armes <karmes@lyft.com>
hansadriaans
pushed a commit
to DataChefHQ/amundsen
that referenced
this pull request
Jun 30, 2022
…ces (amundsen-io#1524) * Adding profile_url field to user model Signed-off-by: Kristen Armes <karmes@lyft.com> * Adding profile_url in more spots for consistency Signed-off-by: Kristen Armes <karmes@lyft.com> * Linting and adding new amundsenrds version to metadata setup.py Signed-off-by: Kristen Armes <karmes@lyft.com> * Fixing test Signed-off-by: Kristen Armes <karmes@lyft.com> * Bumping databuilder version Signed-off-by: Kristen Armes <karmes@lyft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This change adds the
profile_url
field to the user model representations in the databuilder and metadata services. As of today, theprofile_url
field already exists in the frontend and common user models. With this change, theprofile_url
will be able to be populated on the backend instead of the only option being to append it later on the frontend.Tests
I modified any tests that used the User model by passing a
profile_url
to the constructors.Documentation
N/A
CheckList
Make sure you have checked all steps below to ensure a timely review.