Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add profile url to user model in databuilder and metadata services #1524

Merged

Conversation

kristenarmes
Copy link
Contributor

Summary of Changes

This change adds the profile_url field to the user model representations in the databuilder and metadata services. As of today, the profile_url field already exists in the frontend and common user models. With this change, the profile_url will be able to be populated on the backend instead of the only option being to append it later on the frontend.

Tests

I modified any tests that used the User model by passing a profile_url to the constructors.

Documentation

N/A

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

Signed-off-by: Kristen Armes <karmes@lyft.com>
Signed-off-by: Kristen Armes <karmes@lyft.com>
@boring-cyborg boring-cyborg bot added area:databuilder From databuilder folder area:metadata From the metadata folder category:api labels Oct 8, 2021
Signed-off-by: Kristen Armes <karmes@lyft.com>
Signed-off-by: Kristen Armes <karmes@lyft.com>
Signed-off-by: Kristen Armes <karmes@lyft.com>
@allisonsuarez allisonsuarez merged commit c1d1a7e into amundsen-io:main Oct 11, 2021
@kristenarmes kristenarmes deleted the add-profile-url-to-user-model branch October 11, 2021 23:56
amommendes pushed a commit to amommendes/amundsen that referenced this pull request Jan 21, 2022
…ces (amundsen-io#1524)

* Adding profile_url field to user model

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Adding profile_url in more spots for consistency

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Linting and adding new amundsenrds version to metadata setup.py

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Fixing test

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Bumping databuilder version

Signed-off-by: Kristen Armes <karmes@lyft.com>
Signed-off-by: Amom Mendes <amommendes@hotmail.com>
ozandogrultan pushed a commit to deliveryhero/amundsen that referenced this pull request Apr 28, 2022
…ces (amundsen-io#1524)

* Adding profile_url field to user model

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Adding profile_url in more spots for consistency

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Linting and adding new amundsenrds version to metadata setup.py

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Fixing test

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Bumping databuilder version

Signed-off-by: Kristen Armes <karmes@lyft.com>
Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
zacr pushed a commit to SaltIO/amundsen that referenced this pull request May 13, 2022
…ces (amundsen-io#1524)

* Adding profile_url field to user model

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Adding profile_url in more spots for consistency

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Linting and adding new amundsenrds version to metadata setup.py

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Fixing test

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Bumping databuilder version

Signed-off-by: Kristen Armes <karmes@lyft.com>
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this pull request Jun 30, 2022
…ces (amundsen-io#1524)

* Adding profile_url field to user model

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Adding profile_url in more spots for consistency

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Linting and adding new amundsenrds version to metadata setup.py

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Fixing test

Signed-off-by: Kristen Armes <karmes@lyft.com>

* Bumping databuilder version

Signed-off-by: Kristen Armes <karmes@lyft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:databuilder From databuilder folder area:metadata From the metadata folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants