Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: response schema issue in new search API #1585

Merged
merged 1 commit into from
Nov 23, 2021
Merged

fix: response schema issue in new search API #1585

merged 1 commit into from
Nov 23, 2021

Conversation

allisonsuarez
Copy link
Contributor

Signed-off-by: Allison Suarez Miranda asuarezmiranda@lyft.com

Summary of Changes

Tests

Documentation

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

@allisonsuarez
fixed response schema issue
2354147 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez allisonsuarez requested a review from a team as a code owner November 23, 2021 17:08
@boring-cyborg boring-cyborg bot added area:search From the search folder category:api labels Nov 23, 2021
@allisonsuarez allisonsuarez merged commit 9968379 into main Nov 23, 2021
@allisonsuarez allisonsuarez deleted the asm-search-fix branch November 23, 2021 17:10
amommendes pushed a commit to amommendes/amundsen that referenced this pull request Jan 21, 2022
@allisonsuarez @amommendes
fixed response schema issue (amundsen-io#1585)
5022605 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Amom Mendes <amommendes@hotmail.com>
ozandogrultan pushed a commit to deliveryhero/amundsen that referenced this pull request Apr 28, 2022
@allisonsuarez @ozandogrultan
fixed response schema issue (amundsen-io#1585)
683939b 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
zacr pushed a commit to SaltIO/amundsen that referenced this pull request May 13, 2022
@allisonsuarez
fixed response schema issue (amundsen-io#1585)
e8df25a 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this pull request Jun 30, 2022
@allisonsuarez
fixed response schema issue (amundsen-io#1585)
c3096b0 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkunitsk dkunitsk dkunitsk approved these changes

Assignees
No one assigned
Labels
area:search From the search folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allisonsuarez @dkunitsk