Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: FE document update with v2/document search service endpoint use #1619

Merged
merged 10 commits into from
Dec 22, 2021
Merged

feat: FE document update with v2/document search service endpoint use #1619

merged 10 commits into from
Dec 22, 2021

Conversation

allisonsuarez
Copy link
Contributor

@allisonsuarez allisonsuarez commented Dec 13, 2021 •
edited
Loading

Signed-off-by: Allison Suarez Miranda asuarezmiranda@lyft.com

Summary of Changes

  • Search service now takes a single field and value, as well as the resource key to update that single field rather than receiving the entire document, modifying it and then replacing it entirely on ES.

Tests

  • updated existing unit tests

@allisonsuarez
Functional document update
708be37 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@boring-cyborg boring-cyborg bot added area:frontend From the Frontend folder category:api labels Dec 13, 2021
@allisonsuarez allisonsuarez changed the title feat: document update with v2/document search service endpoint use feat: FE document update with v2/document search service endpoint use Dec 15, 2021
@allisonsuarez
updated unit tests
c2cba97 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez
test fix 2
9f4be1d 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez
unit test fixing again, having trouble running lo caly
a17e48e 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez
had the wrong route
455b3ff 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez allisonsuarez marked this pull request as ready for review December 17, 2021 00:18
@allisonsuarez allisonsuarez requested a review from a team as a code owner December 17, 2021 00:18
@allisonsuarez
delete
fe8d786 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez
Merge branch 'main' of github.com:amundsen-io/amundsen into asm-doc-u…
b54b639 
…pdate
@allisonsuarez
rewrite cleaner
07afe59 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez
lint
07f4bd3 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
youngyjd
youngyjd approved these changes Dec 22, 2021
View reviewed changes
Copy link
Member

@youngyjd youngyjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@allisonsuarez
resolved merge cionflict from search pr
1ce6419 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez allisonsuarez merged commit 63a3139 into main Dec 22, 2021
@allisonsuarez allisonsuarez deleted the asm-doc-update branch December 22, 2021 20:01
amommendes pushed a commit to amommendes/amundsen that referenced this pull request Jan 21, 2022
@allisonsuarez @amommendes
feat: FE document update with v2/document search service endpoint use (…
bbfc1a4 
…amundsen-io#1619)

* Functional document update

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* updated unit tests

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* test fix 2

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* unit test fixing again, having trouble running lo caly

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* had the wrong route

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* delete

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* rewrite cleaner

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* lint

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Amom Mendes <amommendes@hotmail.com>
ozandogrultan pushed a commit to deliveryhero/amundsen that referenced this pull request Apr 28, 2022
@allisonsuarez @ozandogrultan
feat: FE document update with v2/document search service endpoint use (…
bcffc4a 
…amundsen-io#1619)

* Functional document update

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* updated unit tests

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* test fix 2

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* unit test fixing again, having trouble running lo caly

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* had the wrong route

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* delete

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* rewrite cleaner

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* lint

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
zacr pushed a commit to SaltIO/amundsen that referenced this pull request May 13, 2022
@allisonsuarez
feat: FE document update with v2/document search service endpoint use (…
5222094 
…amundsen-io#1619)

* Functional document update

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* updated unit tests

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* test fix 2

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* unit test fixing again, having trouble running lo caly

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* had the wrong route

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* delete

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* rewrite cleaner

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* lint

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this pull request Jun 30, 2022
@allisonsuarez
feat: FE document update with v2/document search service endpoint use (…
7d9d613 
…amundsen-io#1619)

* Functional document update

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* updated unit tests

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* test fix 2

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* unit test fixing again, having trouble running lo caly

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* had the wrong route

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* delete

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* rewrite cleaner

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* lint

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngyjd youngyjd youngyjd approved these changes

@dkunitsk dkunitsk Awaiting requested review from dkunitsk

Assignees
No one assigned
Labels
area:frontend From the Frontend folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@allisonsuarez @dkunitsk @youngyjd