Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error on search with pagination #1622

Merged
merged 3 commits into from
Dec 15, 2021
Merged

fix: error on search with pagination #1622

merged 3 commits into from
Dec 15, 2021

Conversation

allisonsuarez
Copy link
Contributor

Signed-off-by: Allison Suarez Miranda asuarezmiranda@lyft.com

Summary of Changes

Tests

Documentation

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

@allisonsuarez
loggigng
696c6ed 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@boring-cyborg boring-cyborg bot added area:search From the search folder category:proxy labels Dec 15, 2021
@allisonsuarez
fixed dummy bug of the century
b978d45 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez allisonsuarez marked this pull request as ready for review December 15, 2021 22:11
@allisonsuarez allisonsuarez requested a review from a team as a code owner December 15, 2021 22:11
@allisonsuarez
remove leftover code
91bb2d1 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez allisonsuarez merged commit 9966fbc into main Dec 15, 2021
@allisonsuarez allisonsuarez deleted the asm-pgination-fix branch December 15, 2021 22:32
amommendes pushed a commit to amommendes/amundsen that referenced this pull request Jan 21, 2022
@allisonsuarez @amommendes
fix: error on search with pagination (amundsen-io#1622)
6f834d0 
* loggigng

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* fixed dummy bug of the century

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* remove leftover code

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Amom Mendes <amommendes@hotmail.com>
ozandogrultan pushed a commit to deliveryhero/amundsen that referenced this pull request Apr 28, 2022
@allisonsuarez @ozandogrultan
fix: error on search with pagination (amundsen-io#1622)
beb086f 
* loggigng

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* fixed dummy bug of the century

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* remove leftover code

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
zacr pushed a commit to SaltIO/amundsen that referenced this pull request May 13, 2022
@allisonsuarez
fix: error on search with pagination (amundsen-io#1622)
98ec60d 
* loggigng

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* fixed dummy bug of the century

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* remove leftover code

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this pull request Jun 30, 2022
@allisonsuarez
fix: error on search with pagination (amundsen-io#1622)
ea4e2de 
* loggigng

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* fixed dummy bug of the century

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* remove leftover code

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkunitsk dkunitsk dkunitsk approved these changes

Assignees
No one assigned
Labels
area:search From the search folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allisonsuarez @dkunitsk