Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use new search endpoint in FE and add search filter operation selection #1623

Merged
merged 26 commits into from
Dec 22, 2021
Merged

feat: Use new search endpoint in FE and add search filter operation selection #1623

merged 26 commits into from
Dec 22, 2021

Commits on Dec 16, 2021

  1. almost there 

    Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
    @allisonsuarez @kristenarmes
    allisonsuarez authored and kristenarmes committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    957c859 View commit details
    Browse the repository at this point in the history

  2. almost done 

    Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
    @allisonsuarez @kristenarmes
    allisonsuarez authored and kristenarmes committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    9a133d6 View commit details
    Browse the repository at this point in the history

  3. FE search API correctly requests search service and responds, need to… 

    … make the ts changes needed to show changes in FE

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
    @allisonsuarez @kristenarmes
    allisonsuarez authored and kristenarmes committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    25b855b View commit details
    Browse the repository at this point in the history

  4. correct mappings for resource results 

    Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
    @allisonsuarez @kristenarmes
    allisonsuarez authored and kristenarmes committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    fb4a504 View commit details
    Browse the repository at this point in the history

  5. SEARCH IS FUNCTIONAL WITH NEW API 

    Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
    @allisonsuarez @kristenarmes
    allisonsuarez authored and kristenarmes committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    6a93b16 View commit details
    Browse the repository at this point in the history

  6. cleanup 

    Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
    @allisonsuarez @kristenarmes
    allisonsuarez authored and kristenarmes committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    480e7e7 View commit details
    Browse the repository at this point in the history

  7. Majority of the work done for filter operation selection using new se… 

    …arch api

Signed-off-by: Kristen Armes <karmes@lyft.com>
    @kristenarmes
    kristenarmes committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    88704f8 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2021

  1. Fixing resource specific search with filters and clear filters behavior 

    Signed-off-by: Kristen Armes <karmes@lyft.com>
    @kristenarmes
    kristenarmes committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    507f2d3 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2021

  1. Fixing js tests and betterer issues 

    Signed-off-by: Kristen Armes <karmes@lyft.com>
    @kristenarmes
    kristenarmes committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    cc32985 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2021

  1. Fixing python test and lint/betterer 

    Signed-off-by: Kristen Armes <karmes@lyft.com>
    @kristenarmes
    kristenarmes committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    1b05099 View commit details
    Browse the repository at this point in the history

  2. Betterer improvements/test fixes 

    Signed-off-by: Kristen Armes <karmes@lyft.com>
    @kristenarmes
    kristenarmes committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    cca232b View commit details
    Browse the repository at this point in the history

  3. removed v0 because it is not needed or accesible anymore, and added u… 

    …nit tests for v1

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
    @allisonsuarez
    allisonsuarez committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    852817c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'search-filter-operation-selection' of github.com:kriste… 

    …narmes/amundsen into search-filter-operation-selection
    @allisonsuarez
    allisonsuarez committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    06c33b2 View commit details
    Browse the repository at this point in the history

  5. a bit of cleanup from utils, not done yet 

    Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
    @allisonsuarez
    allisonsuarez committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    91d7b02 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2021

  1. lint fixes 

    Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
    @allisonsuarez
    allisonsuarez committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    39ad099 View commit details
    Browse the repository at this point in the history

  2. lint 

    Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
    @allisonsuarez
    allisonsuarez committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    89bbd90 View commit details
    Browse the repository at this point in the history

  3. test _transform_filters 

    Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
    @allisonsuarez
    allisonsuarez committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    20fe151 View commit details
    Browse the repository at this point in the history

  4. lint 

    Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
    @allisonsuarez
    allisonsuarez committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    0c1fc6d View commit details
    Browse the repository at this point in the history

  5. Adding description and timestamp to dashboard mapping and adding js t… 

    …ests

Signed-off-by: Kristen Armes <karmes@lyft.com>
    @kristenarmes
    kristenarmes committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    f0c35a3 View commit details
    Browse the repository at this point in the history

  6. Addressing PR comments 

    Signed-off-by: Kristen Armes <karmes@lyft.com>
    @kristenarmes
    kristenarmes committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    32d5963 View commit details
    Browse the repository at this point in the history

  7. lint 

    Signed-off-by: Kristen Armes <karmes@lyft.com>
    @kristenarmes
    kristenarmes committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    7fac169 View commit details
    Browse the repository at this point in the history

  8. Verified that badge is primitive string type during search, cleaned u… 

    …p check

Signed-off-by: Kristen Armes <karmes@lyft.com>
    @kristenarmes
    kristenarmes committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    e91866d View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2021

  1. Changing the name of the config that optionally restricts filter oper… 

    …ations to be more clear on what it does

Signed-off-by: Kristen Armes <karmes@lyft.com>
    @kristenarmes
    kristenarmes committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    7467d0c View commit details
    Browse the repository at this point in the history

  2. If a filter term is deleted, remove the category from the filter stat… 

    …e instead of keeping it stored as an undefined value

Signed-off-by: Kristen Armes <karmes@lyft.com>
    @kristenarmes
    kristenarmes committed Dec 22, 2021
    1 Configuration menu
    Copy the full SHA
    b84387a View commit details
    Browse the repository at this point in the history

  3. Bumping major FE version 

    Signed-off-by: Kristen Armes <karmes@lyft.com>
    @kristenarmes
    kristenarmes committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    344fe03 View commit details
    Browse the repository at this point in the history

  4. Using destructuring instead of delete for removing empty filter 

    Signed-off-by: Kristen Armes <karmes@lyft.com>
    @kristenarmes
    kristenarmes committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    8eb9856 View commit details
    Browse the repository at this point in the history