-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable UI config overrides post build #1830
Merged
Golodhros
merged 5 commits into
amundsen-io:main
from
rajasekharreddyparvatha:asm-apply-external-app-config
May 11, 2022
Merged
feat: enable UI config overrides post build #1830
Golodhros
merged 5 commits into
amundsen-io:main
from
rajasekharreddyparvatha:asm-apply-external-app-config
May 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Golodhros
approved these changes
Apr 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: rajasekhar reddy <reddy.rajasekhar.parvatha@gmail.com>
933412c
to
ad24ac3
Compare
could we update the pr description so that everyone is aware of the change? |
fd5cf73
to
49c4607
Compare
Signed-off-by: Aneesh Joseph <kaneeshjoseph@gmail.com>
49c4607
to
dde0408
Compare
Signed-off-by: rajasekhar reddy <reddy.rajasekhar.parvatha@gmail.com>
5599d32
to
64e8682
Compare
Signed-off-by: Aneesh Joseph <kaneeshjoseph@gmail.com>
@feng-tao , done . can you please help run the PR tests |
Signed-off-by: rajasekhar reddy <reddy.rajasekhar.parvatha@gmail.com>
03f2522
to
274b40e
Compare
Awesome work, congrats on your first merged pull request! |
zacr
pushed a commit
to SaltIO/amundsen
that referenced
this pull request
May 13, 2022
* Apply App config with out rebuild the application Signed-off-by: rajasekhar reddy <reddy.rajasekhar.parvatha@gmail.com> * use config override if JS_CONFIG_OVERRIDE_ENABLED is set Signed-off-by: Aneesh Joseph <kaneeshjoseph@gmail.com> * Fixed lint errors Signed-off-by: rajasekhar reddy <reddy.rajasekhar.parvatha@gmail.com> * fix lint errors Signed-off-by: Aneesh Joseph <kaneeshjoseph@gmail.com> * Resolved lint errors Signed-off-by: rajasekhar reddy <reddy.rajasekhar.parvatha@gmail.com> Co-authored-by: Aneesh Joseph <kaneeshjoseph@gmail.com>
hansadriaans
pushed a commit
to DataChefHQ/amundsen
that referenced
this pull request
Jun 30, 2022
* Apply App config with out rebuild the application Signed-off-by: rajasekhar reddy <reddy.rajasekhar.parvatha@gmail.com> * use config override if JS_CONFIG_OVERRIDE_ENABLED is set Signed-off-by: Aneesh Joseph <kaneeshjoseph@gmail.com> * Fixed lint errors Signed-off-by: rajasekhar reddy <reddy.rajasekhar.parvatha@gmail.com> * fix lint errors Signed-off-by: Aneesh Joseph <kaneeshjoseph@gmail.com> * Resolved lint errors Signed-off-by: rajasekhar reddy <reddy.rajasekhar.parvatha@gmail.com> Co-authored-by: Aneesh Joseph <kaneeshjoseph@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: rajasekhar reddy reddy.rajasekhar.parvatha@gmail.com
Summary of Changes
Currently the Amundsen frontend needs to be rebuilt for any config change (example: enabling dashboards, enabling ML features etc)
This feature allows this frontend appConfig to be overriden by an externally injected js file (example: via helmchart volume mounts, docker-compose volumes etc)
This will make it easier to run amundsen with custom config without the need to rebuild from source.
Sample External config js file
Create new js file with name as config-external.js in static directory as below
filename : config-external.js
Tests
Documentation
CheckList
Make sure you have checked all steps below to ensure a timely review.