fix: fixes tour not resetting on different pages #1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Golodhros
requested review from
ttannis,
allisonsuarez,
feng-tao,
dorianj,
verdan,
mgorsk1,
sewardgw,
youngyjd and
dechoma
as code owners
allisonsuarez
approved these changes
May 5, 2022
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
allisonsuarez
added a commit
that referenced
this pull request
May 12, 2022
* chore: update search service to use new search mappings Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * needed fields back Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated index name to point to new index Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Added deprecation warning log to old ES client Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * made fixtures match new mappings for tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed other unit ests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * remove print and import unused Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added docs explaining how to transition to /v2/search Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * bit more doc Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * change to keep BW compatibility and add new functionality Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * a bit of cleanup and comments for clarity Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more cleanup and manual testing of new search Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated all unit tests and initialize proxy classes according to bww comp functionality Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated docs Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed flake and mypy errors Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more mypy Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * sort imports in v3 Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * implemented most feedback need to do more manual testing and run unit tests + linter Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed import Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated doc Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * oops Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fix Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fix mypy issue Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * type removed Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more config cleanup and some clarifications Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fix: toggle filter should clear when off (#1848) * fix: toggle filter should clear when off Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint fix Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated unit test Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * suggestion Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Refactoring various column details and adding type metadata to the table metadata FE model (#1847) Signed-off-by: Kristen Armes <karmes@lyft.com> * fix: fixes tour not resetting on different pages (#1849) Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com> * fix: better behavior for search filters (#1852) * fix: better behavior for application of filters Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * explicit comparison to None Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * 2nd round of feedback plus more context Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added filters change from different PR and removed deprecated configs Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * chore: update search service to use new search mappings Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * needed fields back Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated index name to point to new index Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Added deprecation warning log to old ES client Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * made fixtures match new mappings for tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed other unit ests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * remove print and import unused Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added docs explaining how to transition to /v2/search Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * bit more doc Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * change to keep BW compatibility and add new functionality Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * a bit of cleanup and comments for clarity Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more cleanup and manual testing of new search Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated all unit tests and initialize proxy classes according to bww comp functionality Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated docs Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed flake and mypy errors Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more mypy Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * sort imports in v3 Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * implemented most feedback need to do more manual testing and run unit tests + linter Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed import Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated doc Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * oops Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fix Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fix mypy issue Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * type removed Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more config cleanup and some clarifications Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * 2nd round of feedback plus more context Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added filters change from different PR and removed deprecated configs Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Revert "Merge branch 'asm-search-with-new-mappings' of github.com:amundsen-io/amundsen into asm-search-with-new-mappings" This reverts commit 49c5c34, reversing changes made to e14b541. * fix args kwards Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * deprecating config Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * deprecating config Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * args fix Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * readme update Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * conf Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * flake Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed new Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * type ignore Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * https://peps.python.org/pep-0484/\#arbitrary-argument-lists-and-default-argument-values Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Empty-Commit Co-authored-by: Kristen Armes <6732445+kristenarmes@users.noreply.github.com> Co-authored-by: Marcos Iglesias <190833+Golodhros@users.noreply.github.com>
zacr
pushed a commit
to SaltIO/amundsen
that referenced
this pull request
May 13, 2022
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
zacr
pushed a commit
to SaltIO/amundsen
that referenced
this pull request
May 13, 2022
) * chore: update search service to use new search mappings Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * needed fields back Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated index name to point to new index Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Added deprecation warning log to old ES client Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * made fixtures match new mappings for tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed other unit ests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * remove print and import unused Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added docs explaining how to transition to /v2/search Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * bit more doc Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * change to keep BW compatibility and add new functionality Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * a bit of cleanup and comments for clarity Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more cleanup and manual testing of new search Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated all unit tests and initialize proxy classes according to bww comp functionality Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated docs Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed flake and mypy errors Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more mypy Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * sort imports in v3 Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * implemented most feedback need to do more manual testing and run unit tests + linter Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed import Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated doc Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * oops Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fix Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fix mypy issue Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * type removed Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more config cleanup and some clarifications Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fix: toggle filter should clear when off (amundsen-io#1848) * fix: toggle filter should clear when off Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint fix Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated unit test Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * suggestion Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Refactoring various column details and adding type metadata to the table metadata FE model (amundsen-io#1847) Signed-off-by: Kristen Armes <karmes@lyft.com> * fix: fixes tour not resetting on different pages (amundsen-io#1849) Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com> * fix: better behavior for search filters (amundsen-io#1852) * fix: better behavior for application of filters Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * explicit comparison to None Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * 2nd round of feedback plus more context Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added filters change from different PR and removed deprecated configs Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * chore: update search service to use new search mappings Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * needed fields back Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated index name to point to new index Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Added deprecation warning log to old ES client Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * made fixtures match new mappings for tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed other unit ests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * remove print and import unused Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added docs explaining how to transition to /v2/search Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * bit more doc Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * change to keep BW compatibility and add new functionality Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * a bit of cleanup and comments for clarity Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more cleanup and manual testing of new search Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated all unit tests and initialize proxy classes according to bww comp functionality Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated docs Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed flake and mypy errors Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more mypy Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * sort imports in v3 Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * implemented most feedback need to do more manual testing and run unit tests + linter Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed import Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated doc Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * oops Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fix Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fix mypy issue Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * type removed Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more config cleanup and some clarifications Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * 2nd round of feedback plus more context Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added filters change from different PR and removed deprecated configs Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Revert "Merge branch 'asm-search-with-new-mappings' of github.com:amundsen-io/amundsen into asm-search-with-new-mappings" This reverts commit 49c5c34, reversing changes made to e14b541. * fix args kwards Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * deprecating config Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * deprecating config Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * args fix Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * readme update Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * conf Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * flake Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed new Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * type ignore Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * https://peps.python.org/pep-0484/\#arbitrary-argument-lists-and-default-argument-values Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Empty-Commit Co-authored-by: Kristen Armes <6732445+kristenarmes@users.noreply.github.com> Co-authored-by: Marcos Iglesias <190833+Golodhros@users.noreply.github.com>
hansadriaans
pushed a commit
to DataChefHQ/amundsen
that referenced
this pull request
Jun 30, 2022
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
hansadriaans
pushed a commit
to DataChefHQ/amundsen
that referenced
this pull request
Jun 30, 2022
) * chore: update search service to use new search mappings Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * needed fields back Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated index name to point to new index Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Added deprecation warning log to old ES client Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * made fixtures match new mappings for tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed other unit ests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * remove print and import unused Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added docs explaining how to transition to /v2/search Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * bit more doc Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * change to keep BW compatibility and add new functionality Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * a bit of cleanup and comments for clarity Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more cleanup and manual testing of new search Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated all unit tests and initialize proxy classes according to bww comp functionality Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated docs Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed flake and mypy errors Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more mypy Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * sort imports in v3 Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * implemented most feedback need to do more manual testing and run unit tests + linter Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed import Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated doc Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * oops Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fix Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fix mypy issue Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * type removed Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more config cleanup and some clarifications Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fix: toggle filter should clear when off (amundsen-io#1848) * fix: toggle filter should clear when off Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint fix Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated unit test Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * suggestion Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Refactoring various column details and adding type metadata to the table metadata FE model (amundsen-io#1847) Signed-off-by: Kristen Armes <karmes@lyft.com> * fix: fixes tour not resetting on different pages (amundsen-io#1849) Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com> * fix: better behavior for search filters (amundsen-io#1852) * fix: better behavior for application of filters Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * explicit comparison to None Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * 2nd round of feedback plus more context Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added filters change from different PR and removed deprecated configs Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * chore: update search service to use new search mappings Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * needed fields back Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated index name to point to new index Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Added deprecation warning log to old ES client Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * made fixtures match new mappings for tests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed other unit ests Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * remove print and import unused Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added docs explaining how to transition to /v2/search Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * bit more doc Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * change to keep BW compatibility and add new functionality Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * a bit of cleanup and comments for clarity Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more cleanup and manual testing of new search Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated all unit tests and initialize proxy classes according to bww comp functionality Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * lint Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated docs Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed flake and mypy errors Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more mypy Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * sort imports in v3 Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * implemented most feedback need to do more manual testing and run unit tests + linter Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed import Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated doc Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * oops Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fix Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fix mypy issue Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * type removed Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more config cleanup and some clarifications Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * 2nd round of feedback plus more context Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added filters change from different PR and removed deprecated configs Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Revert "Merge branch 'asm-search-with-new-mappings' of github.com:amundsen-io/amundsen into asm-search-with-new-mappings" This reverts commit 49c5c34, reversing changes made to e14b541. * fix args kwards Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * deprecating config Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * deprecating config Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * args fix Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * readme update Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * conf Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * flake Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * fixed new Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * type ignore Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * https://peps.python.org/pep-0484/\#arbitrary-argument-lists-and-default-argument-values Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Empty-Commit Co-authored-by: Kristen Armes <6732445+kristenarmes@users.noreply.github.com> Co-authored-by: Marcos Iglesias <190833+Golodhros@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fixes issue with active Tours not reseting when changing pages
Tests
Manual
Documentation
N/A
CheckList
Make sure you have checked all steps below to ensure a timely review.