feat: search highlighting UI #1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
allisonsuarez
requested review from
Golodhros,
ttannis,
feng-tao,
dorianj,
verdan,
mgorsk1,
sewardgw,
youngyjd,
dechoma and
a team
as code owners
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Golodhros
reviewed
Jun 1, 2022
frontend/amundsen_application/static/js/components/ResourceListItem/DashboardListItem/index.tsx
Outdated
Show resolved
Hide resolved
| {feature.description} | ||
| </div> | ||
| {feature.description && ( | ||
| <div |
There was a problem hiding this comment.
Could we use here a <p> tag instead of a div?
There was a problem hiding this comment.
the styling gets completely messed up when using <p>
frontend/amundsen_application/static/js/components/ResourceListItem/FeatureListItem/index.tsx
Outdated
Show resolved
Hide resolved
...application/static/js/components/ResourceListItem/MetadataHighlightList/highlightingUtils.ts
Outdated
Show resolved
Hide resolved
...application/static/js/components/ResourceListItem/MetadataHighlightList/highlightingUtils.ts
Outdated
Show resolved
Hide resolved
...d/amundsen_application/static/js/components/ResourceListItem/MetadataHighlightList/index.tsx
Outdated
Show resolved
Hide resolved
...d/amundsen_application/static/js/components/ResourceListItem/MetadataHighlightList/index.tsx
Outdated
Show resolved
Hide resolved
frontend/amundsen_application/static/js/components/ResourceListItem/TableListItem/index.tsx
Outdated
Show resolved
Hide resolved
frontend/amundsen_application/static/js/components/ResourceListItem/styles.scss
Outdated
Show resolved
Hide resolved
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide configurable search matching metadata highlighting for tables, dashboards, and features.
