Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes state sharing between tours of different pages #1854

Merged
merged 1 commit into from
May 10, 2022

Conversation

Golodhros
Copy link
Member

Summary of Changes

Fixes issue with tour where we share state between multiple pages' tours

Tests

Manually

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
@Golodhros Golodhros merged commit d376dff into main May 10, 2022
@Golodhros Golodhros deleted the mi-tour-state-fix branch May 10, 2022 23:58
zacr pushed a commit to SaltIO/amundsen that referenced this pull request May 13, 2022
…o#1854)

Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this pull request Jun 30, 2022
…o#1854)

Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend From the Frontend folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants