Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: updated search readme #1859

Merged
merged 1 commit into from
May 23, 2022
Merged

chore: updated search readme #1859

merged 1 commit into from
May 23, 2022

Conversation

allisonsuarez
Copy link
Contributor

Summary of Changes

Tests

Documentation

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

@allisonsuarez allisonsuarez requested a review from a team as a code owner May 12, 2022 21:07
@boring-cyborg boring-cyborg bot added area:all Related to all the project area:docs area:search From the search folder labels May 12, 2022
@allisonsuarez allisonsuarez merged commit 55c34e7 into main May 23, 2022
@allisonsuarez allisonsuarez deleted the asm-readme-search branch May 23, 2022 17:45
allisonsuarez added a commit that referenced this pull request Jun 9, 2022
@allisonsuarez
chore: updated search readme (#1859)
aef1ea0
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this pull request Jun 30, 2022
@allisonsuarez
chore: updated search readme (amundsen-io#1859)
0073c8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feng-tao feng-tao feng-tao approved these changes

Assignees
No one assigned
Labels
area:all Related to all the project area:search From the search folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allisonsuarez @feng-tao