Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add postgres compatibility in HiveTableLastUpdatedExtractor #1879

Conversation

chonyy
Copy link
Contributor

@chonyy chonyy commented May 29, 2022

Summary of Changes

Tests

This change has been running in our production environment for a couple of months. I believe no additional unit test is needed since it's simply fixing an unexpected behavior.

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

@chonyy chonyy requested a review from a team as a code owner May 29, 2022 13:01
@boring-cyborg boring-cyborg bot added the area:databuilder From databuilder folder label May 29, 2022
@chonyy chonyy force-pushed the postgres-compatibility-in-hive-table-last-updated-extractor branch from ae5d286 to 27454f2 Compare May 29, 2022 13:02
@chonyy
Copy link
Contributor Author

chonyy commented May 30, 2022

Same unit test import problem as mentioned here: #1878 (comment)

@chonyy chonyy force-pushed the postgres-compatibility-in-hive-table-last-updated-extractor branch from 27454f2 to bdc06cc Compare June 8, 2022 17:34
@feng-tao
Copy link
Member

@chonyy could you rebase and fix the CI? will take a look once it is updated. sorry for the late

@stale
Copy link

stale bot commented Jul 7, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Jul 7, 2022
@chonyy chonyy force-pushed the postgres-compatibility-in-hive-table-last-updated-extractor branch from bdc06cc to 0431f18 Compare July 12, 2022 06:05
Signed-off-by: Tony Chou <tcheon8788@gmail.com>
@chonyy chonyy force-pushed the postgres-compatibility-in-hive-table-last-updated-extractor branch from e4a8550 to b37637d Compare July 12, 2022 06:13
@stale stale bot removed stale labels Jul 12, 2022
…her it's postgres or not

Signed-off-by: Tony Chou <tcheon8788@gmail.com>
@chonyy chonyy force-pushed the postgres-compatibility-in-hive-table-last-updated-extractor branch from b37637d to d9af982 Compare July 12, 2022 06:29
@chonyy
Copy link
Contributor Author

chonyy commented Jul 12, 2022

Hi @feng-tao , all ci unit tests are passed. Pls help me take a look at it when you have time, thanks 🙏

@stale
Copy link

stale bot commented Jul 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Jul 30, 2022
@stale stale bot removed the stale label Aug 2, 2022
@feng-tao feng-tao merged commit ecfbf37 into amundsen-io:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:databuilder From databuilder folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants