-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add postgres compatibility in HiveTableLastUpdatedExtractor #1879
fix: Add postgres compatibility in HiveTableLastUpdatedExtractor #1879
Conversation
ae5d286
to
27454f2
Compare
Same unit test import problem as mentioned here: #1878 (comment) |
27454f2
to
bdc06cc
Compare
@chonyy could you rebase and fix the CI? will take a look once it is updated. sorry for the late |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
bdc06cc
to
0431f18
Compare
Signed-off-by: Tony Chou <tcheon8788@gmail.com>
e4a8550
to
b37637d
Compare
…her it's postgres or not Signed-off-by: Tony Chou <tcheon8788@gmail.com>
b37637d
to
d9af982
Compare
Hi @feng-tao , all ci unit tests are passed. Pls help me take a look at it when you have time, thanks 🙏 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Summary of Changes
Tests
This change has been running in our production environment for a couple of months. I believe no additional unit test is needed since it's simply fixing an unexpected behavior.
CheckList
Make sure you have checked all steps below to ensure a timely review.