Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Amazon EventBridge Extractor #1881

Merged
merged 1 commit into from
Jun 18, 2022

Conversation

ka1319
Copy link
Contributor

@ka1319 ka1319 commented May 31, 2022

Summary of Changes

Added a new extractor for fetching schema metadata from AWS EventBridge schema registries.

Tests

Added databuilder/tests/unit/extractor/test_eventbridge_extractor.py for testing the new extractor.

Documentation

Updated README.md and databuilder/README.md to reflect the addition of the new extractor.

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

@ka1319 ka1319 requested a review from a team as a code owner May 31, 2022 14:39
@boring-cyborg boring-cyborg bot added area:databuilder From databuilder folder area:all Related to all the project area:docs labels May 31, 2022
@ka1319 ka1319 force-pushed the feat/eventbridge-extractor branch 3 times, most recently from 6696af5 to 408781f Compare May 31, 2022 14:57
Signed-off-by: Kian Ahrabian <kahrabian@yahoo.com>
@ka1319 ka1319 force-pushed the feat/eventbridge-extractor branch from 408781f to 11bcb90 Compare May 31, 2022 15:05
@stale
Copy link

stale bot commented Jun 18, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Jun 18, 2022
@feng-tao feng-tao added the keep fresh Disables stalebot from closing an issue label Jun 18, 2022
@stale stale bot removed the stale label Jun 18, 2022
@feng-tao
Copy link
Member

thanks @kahrabian for the contribution!

@feng-tao feng-tao merged commit 4a4531e into amundsen-io:main Jun 18, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 18, 2022

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:all Related to all the project area:databuilder From databuilder folder keep fresh Disables stalebot from closing an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants