Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Highlighting styling improvement #1887

Merged
merged 1 commit into from
Jun 7, 2022
Merged

fix: Highlighting styling improvement #1887

merged 1 commit into from
Jun 7, 2022

Conversation

allisonsuarez
Copy link
Contributor

  • added more spacing for matching columns and other metadata field matches
  • Removed gray text

@allisonsuarez
styling change
ec9779c 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@boring-cyborg boring-cyborg bot added area:frontend From the Frontend folder category:ui labels Jun 6, 2022
Golodhros
Golodhros approved these changes Jun 6, 2022
View reviewed changes
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@allisonsuarez allisonsuarez merged commit e8fee8c into main Jun 7, 2022
@allisonsuarez allisonsuarez deleted the asm-fix-styling-highlights branch June 7, 2022 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Golodhros Golodhros Golodhros approved these changes

@ttannis ttannis Awaiting requested review from ttannis ttannis is a code owner

@feng-tao feng-tao Awaiting requested review from feng-tao feng-tao is a code owner

@dorianj dorianj Awaiting requested review from dorianj

@verdan verdan Awaiting requested review from verdan verdan is a code owner

@mgorsk1 mgorsk1 Awaiting requested review from mgorsk1 mgorsk1 is a code owner

@sewardgw sewardgw Awaiting requested review from sewardgw sewardgw is a code owner

@youngyjd youngyjd Awaiting requested review from youngyjd youngyjd is a code owner

@dechoma dechoma Awaiting requested review from dechoma dechoma is a code owner

Assignees
No one assigned
Labels
area:frontend From the Frontend folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allisonsuarez @Golodhros