-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat and perf: Add support for Multiple Programmatic Descriptions and Table level Badges #1903
feat and perf: Add support for Multiple Programmatic Descriptions and Table level Badges #1903
Conversation
Signed-off-by: Akira Takihara Wang <akiraw@squareup.com>
@chonyy fixed it! |
Hmm looks like some issue with |
Signed-off-by: Akira Takihara Wang <akiraw@squareup.com>
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
@kristenarmes @dkunitsk @allisonsuarez could you all take a look? |
This reverts commit 98e2580.
Signed-off-by: Akira Takihara Wang <akiraw@squareup.com>
Signed-off-by: Akira Takihara Wang <akiraw@squareup.com>
Signed-off-by: Akira Takihara Wang <akiraw@squareup.com>
Signed-off-by: Akira Takihara Wang <akiraw@squareup.com>
This reverts commit 98e2580. Signed-off-by: Akira Takihara Wang <akiraw@squareup.com>
Signed-off-by: Akira Takihara Wang <akiraw@squareup.com>
…s://github.com/akiratwang/amundsen into feature/add_table_badges_and_programmatic_desc
Summary of Changes
Hey team, thanks for reviewing this PR! This is a newer PR with the correct sign-off.
The motivation originates from #1828 which makes the original code quite convoluted and creates duplicated nodes/records. However, with #1877 being an epic speed-up to the original
Neo4JCSV
process (hopefully the PR is merged soon), the original naive method of duplicatingTableMetadata
for multiple programmatic descriptions does not work.The changes here aim to mitigate this issue and allow multiple programmatic descriptions to be added and also benefit from the significantly reduced runtime using
APOC
.Change Log:
TableMetadata
example/scripts/sample_base_postgres_metadata_extractor
for examplesis_view
flag and use the newbadges
argument instead (as its generalised). We've removed the flag from our prod instance without issues.Example Changes:
(all sensitive info has been removed)
Tests
The code has been tested and deployed in our prod environment and I am more than happy to have a quick knowledge share on my changes / tests. This consists of over 40 thousand tables and 500,000 thousand columns.
However testing from the core repo side would be appreciated as our Amundsen is greatly modified and as such, our environment will not capture all test cases.
CheckList
Make sure you have checked all steps below to ensure a timely review.