Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixing markdown for truncated column descriptions in the table #1905

Merged

Conversation

kristenarmes
Copy link
Contributor

Signed-off-by: Kristen Armes karmes@lyft.com

Summary of Changes

Markdown styling has been available for table and column descriptions, but it would not display the styling correctly for the truncated descriptions that are displayed in the table detail page under each column name. This is a small change to address that so the markdown will display correctly.

Tests

N/A

Documentation

N/A

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

Signed-off-by: Kristen Armes <karmes@lyft.com>
Copy link
Contributor

@allisonsuarez allisonsuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@allisonsuarez allisonsuarez merged commit 7107864 into amundsen-io:main Jun 16, 2022
@kristenarmes kristenarmes deleted the fix-markdown-description-preview branch June 16, 2022 21:16
@feng-tao
Copy link
Member

@kristenarmes @allisonsuarez do we allow markdown for column description as well? if so, could you point me the code where the limit of comment length for table and column level comment?

@kristenarmes
Copy link
Contributor Author

@feng-tao Here is the default config that defines max lengths for both. Markdown has been around for both table and column descriptions, but it just wasn't displaying correctly in the description preview under each column name before

@feng-tao
Copy link
Member

interesting, I thought we only supported table comment markdown before :) It must be a long time since I look at this code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend From the Frontend folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants