Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding new Trino type parser and other type metadata updates #1917

Merged
merged 6 commits into from
Jul 7, 2022

Conversation

kristenarmes
Copy link
Contributor

Signed-off-by: Kristen Armes karmes@lyft.com

Summary of Changes

  • Added new Trino type metadata parser
  • Added Type_Metadata to the labels permitted to have badges
  • Made description and badges private class variables accessible by getters and setters instead of part of the constructor. This allows for checks to make sure they are supported at that nested level. The frontend does not support descriptions or badges for nodes that have a parent of ColumnMetadata or ArrayTypeMetadata due to the way the nesting is displayed.

Tests

Added tests for the Trino parser, testing the usage of the Trino parser with the ComplexTypeTransformer, and added a new test to make sure descriptions and badges aren't set for unsupported types.

Documentation

N/A

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

Signed-off-by: Kristen Armes <karmes@lyft.com>
@boring-cyborg boring-cyborg bot added area:databuilder From databuilder folder category:models labels Jun 29, 2022
Signed-off-by: Kristen Armes <karmes@lyft.com>
@kristenarmes kristenarmes marked this pull request as ready for review June 29, 2022 22:06
@kristenarmes kristenarmes requested a review from a team as a code owner June 29, 2022 22:06
databuilder/databuilder/models/type_metadata.py Outdated Show resolved Hide resolved
…en't supported

Signed-off-by: Kristen Armes <karmes@lyft.com>
Signed-off-by: Kristen Armes <karmes@lyft.com>
Signed-off-by: Kristen Armes <karmes@lyft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:databuilder From databuilder folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants