Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Extract search results per page into a config variable #1922

Merged
merged 2 commits into from
Jul 5, 2022

Conversation

ozandogrultan
Copy link
Contributor

Signed-off-by: Ozan Dogrultan ozan.dogrultan@deliveryhero.com

Summary of Changes

Instead of retrieving the search results per page from a constant, this PR introduces the changes to have configurable search results per page.

Tests

All related tests using the old constant (RESULTS_PER_PAGE) are updated.

Documentation

N/A

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Golodhros Golodhros merged commit 23f68fa into amundsen-io:main Jul 5, 2022
@Golodhros
Copy link
Member

Thanks again for your contribution @ozandogrultan !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend From the Frontend folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants