Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change TabsComponent styling to only be sticky in certain cases #1925

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

kristenarmes
Copy link
Contributor

Signed-off-by: Kristen Armes karmes@lyft.com

Summary of Changes

Changing the TabsComponent styling to only be sticky on pages that use scrolling tables or lists, including TableDetailPage, DashboardPage, and FeaturePage.

Tests

N/A

Documentation

N/A

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

…scrolling tables/lists

Signed-off-by: Kristen Armes <karmes@lyft.com>
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kristenarmes kristenarmes merged commit 2533f29 into amundsen-io:main Jul 7, 2022
@kristenarmes kristenarmes deleted the sticky-header-fixes branch July 7, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend From the Frontend folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants