Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add get_dashbaord support for neptune #1927

Conversation

Owen-CH-Leung
Copy link
Contributor

Summary of Changes

Currently, using AWS Neptune as the backend, the get_dashboard function is not implemented at the NeptuneGremlinProxy, AbstractGremlinProxy and BaseProxy, which means that the dashboard at frontend does not display properly due to the missing implementation. For details, you can refer to this chat :

https://amundsenworkspace.slack.com/archives/C01A87A5EUU/p1653483057967299?thread_ts=1653374819.089879&cid=C01A87A5EUU

Hence, this PR attempts to create such functionality so that dashbaord works fine using Neptune as backend.

Tests

I tested the code using my company's aws environment (which uses AWS neptune & opensearch as the backend) and it worked fine.

Documentation

N/A

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • [ x ] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • [ x ] PR includes a summary of changes.
  • [ x ] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • [ x ] In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

@Owen-CH-Leung Owen-CH-Leung requested a review from a team as a code owner July 10, 2022 16:52
@boring-cyborg boring-cyborg bot added area:metadata From the metadata folder category:proxy labels Jul 10, 2022
Signed-off-by: owenlch <owen.leung2@gmail.com>
@Owen-CH-Leung Owen-CH-Leung force-pushed the feat-add-get_dashboard-support-for-neptune-backend branch from 70c4752 to 771cc0f Compare July 10, 2022 16:53
Signed-off-by: owenlch <owen.leung2@gmail.com>
@feng-tao feng-tao merged commit 876eb42 into amundsen-io:main Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metadata From the metadata folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants