feat: add get_dashbaord support for neptune #1927
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Currently, using AWS Neptune as the backend, the get_dashboard function is not implemented at the
NeptuneGremlinProxy,
AbstractGremlinProxy
andBaseProxy
, which means that the dashboard at frontend does not display properly due to the missing implementation. For details, you can refer to this chat :https://amundsenworkspace.slack.com/archives/C01A87A5EUU/p1653483057967299?thread_ts=1653374819.089879&cid=C01A87A5EUU
Hence, this PR attempts to create such functionality so that dashbaord works fine using Neptune as backend.
Tests
I tested the code using my company's aws environment (which uses AWS neptune & opensearch as the backend) and it worked fine.
Documentation
N/A
CheckList
Make sure you have checked all steps below to ensure a timely review.