Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: driver object pickle error #1944

Merged
merged 2 commits into from
Jul 28, 2022
Merged

fix: driver object pickle error #1944

merged 2 commits into from
Jul 28, 2022

Conversation

allisonsuarez
Copy link
Contributor

@allisonsuarez allisonsuarez commented Jul 28, 2022 •
edited
Loading

Removed neo4j driver config since it can't be used with out config library

@allisonsuarez
fix: driver object pickle error
254b183 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@boring-cyborg boring-cyborg bot added the area:databuilder From databuilder folder label Jul 28, 2022
@allisonsuarez
always used conf w fallback on neo4j extractor
c17dded 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
dkunitsk
dkunitsk approved these changes Jul 28, 2022
View reviewed changes
Copy link

@dkunitsk dkunitsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@allisonsuarez allisonsuarez marked this pull request as ready for review July 28, 2022 02:59
@allisonsuarez allisonsuarez merged commit 879a002 into main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkunitsk dkunitsk dkunitsk approved these changes

@feng-tao feng-tao Awaiting requested review from feng-tao feng-tao is a code owner

@jinhyukchang jinhyukchang Awaiting requested review from jinhyukchang jinhyukchang is a code owner

@dorianj dorianj Awaiting requested review from dorianj

@verdan verdan Awaiting requested review from verdan verdan is a code owner

@mgorsk1 mgorsk1 Awaiting requested review from mgorsk1 mgorsk1 is a code owner

@youngyjd youngyjd Awaiting requested review from youngyjd youngyjd is a code owner

@dechoma dechoma Awaiting requested review from dechoma dechoma is a code owner

@sewardgw sewardgw Awaiting requested review from sewardgw sewardgw is a code owner

Assignees
No one assigned
Labels
area:databuilder From databuilder folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allisonsuarez @dkunitsk