-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add optional configuration to disable Lineage list view links #1958
Merged
Golodhros
merged 8 commits into
amundsen-io:main
from
deliveryhero:feat/lineage-list-view-ui-configuration
Aug 15, 2022
Merged
feat: Add optional configuration to disable Lineage list view links #1958
Golodhros
merged 8 commits into
amundsen-io:main
from
deliveryhero:feat/lineage-list-view-ui-configuration
Aug 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
Golodhros
reviewed
Aug 12, 2022
frontend/amundsen_application/static/js/components/ResourceListItem/TableListItem/index.tsx
Outdated
Show resolved
Hide resolved
frontend/amundsen_application/static/js/pages/TableDetailPage/LineageList/index.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
Golodhros
requested changes
Aug 12, 2022
frontend/amundsen_application/static/js/components/ResourceListItem/TableListItem/index.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
Golodhros
reviewed
Aug 12, 2022
frontend/amundsen_application/static/js/pages/TableDetailPage/LineageList/index.spec.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
Golodhros
approved these changes
Aug 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Golodhros @feng-tao Can we merge this if there are no concerns? We can start using the configuration in our app then 🙂 |
Waiting for @allisonsuarez to take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ozan Dogrultan ozan.dogrultan@deliveryhero.com
Summary of Changes
This PR adds a new optional configuration to existing
TableLineageConfig
, to set up field based rules, which are used to disable "lineage list view" links based on regular expression matching. This config is particularly useful when some of the table resources should appear in the Lineage graph, however are not ingested into catalog or should not be accessible by users.Tests
No test changes are required.
Documentation
A comment added to the new config explaining the purpose.
CheckList
Make sure you have checked all steps below to ensure a timely review.