Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add optional configuration to disable Lineage list view links #1958

Conversation

ozandogrultan
Copy link
Contributor

Signed-off-by: Ozan Dogrultan ozan.dogrultan@deliveryhero.com

Summary of Changes

This PR adds a new optional configuration to existing TableLineageConfig, to set up field based rules, which are used to disable "lineage list view" links based on regular expression matching. This config is particularly useful when some of the table resources should appear in the Lineage graph, however are not ingested into catalog or should not be accessible by users.

Tests

No test changes are required.

Documentation

A comment added to the new config explaining the purpose.

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
Signed-off-by: Ozan Dogrultan <ozan.dogrultan@deliveryhero.com>
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozandogrultan
Copy link
Contributor Author

@Golodhros @feng-tao Can we merge this if there are no concerns? We can start using the configuration in our app then 🙂

@Golodhros
Copy link
Member

Waiting for @allisonsuarez to take a look.

@Golodhros Golodhros merged commit 01d6e8c into amundsen-io:main Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend From the Frontend folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants