Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Change deprecated pytest function #398

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

Wonong
Copy link
Contributor

@Wonong Wonong commented Nov 2, 2020

Signed-off-by: Wonyeong Choi ciwnyg0815@gmail.com

Summary of Changes

Since the assertEquals function has been deprecated, replaced it with the assertEqual function for all test files.

Tests

Passed all existing unit tests

Documentation

pytest doc about deprecated function: https://docs.python.org/3.3/library/unittest.html#deprecated-aliases

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

Signed-off-by: Wonyeong Choi <ciwnyg0815@gmail.com>
@Wonong Wonong changed the title chore: Change deprecated function chore: Change deprecated pytest function Nov 2, 2020
Copy link
Member

@feng-tao feng-tao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@feng-tao feng-tao merged commit 8a559f5 into amundsen-io:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants