Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: watermark sample data to lowercase #403

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

allisonsuarez
Copy link
Contributor

Signed-off-by: Allison Suarez Miranda asuarezmiranda@lyft.com

Summary of Changes

Updated sample_watermark.csv to have all lowercase part_type and fix error from amundsen-io/amundsen#784 .

Tests

N/A

Documentation

N/A

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez allisonsuarez requested a review from a team as a code owner November 5, 2020 23:13
@allisonsuarez allisonsuarez merged commit d91c0c5 into master Nov 5, 2020
@allisonsuarez allisonsuarez deleted the asm-fix-sample-watermark-data branch November 5, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants