Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not all grid attributes written #856

Closed
ipelupessy opened this issue Jun 3, 2022 · 5 comments · Fixed by #947
Closed

not all grid attributes written #856

ipelupessy opened this issue Jun 3, 2022 · 5 comments · Fixed by #947

Comments

@ipelupessy
Copy link
Member

ipelupessy commented Jun 3, 2022

Describe the bug
some grid attributes (of the "hidden" type) like _axes_names or the added derived attributes ("position") are not written with write_set_to_file, hence when reading some
method (e.g. get_axes_names) do not work

To Reproduce

g=new_cartesian_grid((5,5), 1)
write_set_to_file(g,"test.amuse","amuse")
g=read_set_from_file("test.amuse","amuse")
print(g.get_axes_names())

results in:

Exception: do not know how to find axes_names

Expected behavior
that it works

there are a few possible solutions, like _axes_names moving to collection_attributes, needs a bit of care

@stale
Copy link

stale bot commented Aug 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issues that have been around for a while without updates label Aug 2, 2022
@stale stale bot closed this as completed Aug 30, 2022
@ipelupessy
Copy link
Member Author

this needs to be confirmed as fixed or not 100% fixed (think the latter)

@ipelupessy ipelupessy reopened this Aug 30, 2022
@stale stale bot removed stale Issues that have been around for a while without updates labels Aug 30, 2022
@stale
Copy link

stale bot commented Oct 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issues that have been around for a while without updates label Oct 31, 2022
@stale stale bot closed this as completed Nov 28, 2022
@rieder rieder reopened this Nov 28, 2022
@rieder rieder removed the stale Issues that have been around for a while without updates label Nov 28, 2022 — with Slack
@Sbte
Copy link
Contributor

Sbte commented Dec 13, 2022

I'm running into this as well. I also tried to fix it, but it seems difficult with how everything is set up, and without much knowledge of the underlying code.

Sbte added a commit to Sbte/amuse that referenced this issue Jan 31, 2023
Sbte added a commit to Sbte/amuse that referenced this issue Jan 31, 2023
@stale
Copy link

stale bot commented Feb 11, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issues that have been around for a while without updates label Feb 11, 2023
@rieder rieder added keep-open and removed stale Issues that have been around for a while without updates labels Feb 12, 2023
ipelupessy added a commit to ipelupessy/amuse that referenced this issue Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants