Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for constant mass loss in Mmams #859

Merged
merged 3 commits into from
Dec 1, 2022

Conversation

ipelupessy
Copy link
Member

wip for Tina

@TNeumann98
Copy link

Mesa_r2208 works but
Mesa_r15140 can not be downloaded (Python version error)

@stale
Copy link

stale bot commented Aug 15, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issues that have been around for a while without updates label Aug 15, 2022
@stale stale bot removed the stale Issues that have been around for a while without updates label Aug 15, 2022
@@ -12,7 +16,13 @@ real mmas::mass_loss() {
// if (age < 0.75) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change back because of misunderstanding: mass_loss over the stellar lifetime not mass loss of merger product

@spzwart spzwart closed this Dec 1, 2022
@spzwart
Copy link
Contributor

spzwart commented Dec 1, 2022

Seems ok. Will test it now

@rieder rieder reopened this Dec 1, 2022
@rieder
Copy link
Member

rieder commented Dec 1, 2022

First test, then approve 🙂

Copy link

@TNeumann98 TNeumann98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked, can be added to main :)

@rieder rieder merged commit 5108a57 into amusecode:main Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants