Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix issue for #850 #869

Merged
merged 12 commits into from
Nov 30, 2022
Merged

Bugfix issue for #850 #869

merged 12 commits into from
Nov 30, 2022

Conversation

rieder
Copy link
Member

@rieder rieder commented Jul 5, 2022 •
edited
Loading

  • Test issue 850
  • Add test to workflow for this branch
  • Fix issue
  • Remove workflow
  • Merge & Remove branch

@rieder rieder linked an issue Jul 5, 2022 that may be closed by this pull request
single star not evolved in presence of binary #850
Closed
@rieder
Copy link
Member Author

rieder commented Jul 5, 2022

The test_issue_850 workflow tests issue #850 - it currently fails so the bug is still there (of course, since no fix has been made yet).
I'm not sure what causes the issue, but it is clear that SeBa does not evolve star[1] from the test if a binary of stars[0,2] is added. Not sure if this extends to SeBa only evolving stars that are also in a binary (if any binary is added), perhaps also add this to the test?
(cc @silviatoonen)

@stale
Copy link

stale bot commented Sep 6, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issues that have been around for a while without updates label Sep 6, 2022
@ipelupessy
Copy link
Member

see comment i made in #850

@stale stale bot removed the stale Issues that have been around for a while without updates label Sep 8, 2022
@stale
Copy link

stale bot commented Nov 7, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issues that have been around for a while without updates label Nov 7, 2022
@ipelupessy
Copy link
Member

this can be fixed see the comment on #850

@silviatoonen
Copy link
Contributor

silviatoonen commented Nov 7, 2022 via email

@stale stale bot removed stale Issues that have been around for a while without updates labels Nov 30, 2022
@ipelupessy
Copy link
Member

if the test cases are ok, its prob ok

@rieder
Copy link
Member Author

rieder commented Nov 30, 2022

Test is successful, so are the regular SeBa tests. Merging.

@rieder rieder merged commit 4a69916 into main Nov 30, 2022
@rieder rieder deleted the bug/850 branch November 30, 2022 14:15
@silviatoonen
Copy link
Contributor

silviatoonen commented Nov 30, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipelupessy ipelupessy ipelupessy approved these changes

@silviatoonen silviatoonen Awaiting requested review from silviatoonen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

single star not evolved in presence of binary
3 participants
@rieder @ipelupessy @silviatoonen