Add make clean in CDK Dockerfile #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Since CDK now build image from local source, it makes more sense that user does not need to take care to clean up local repository before CDK synth & deploy, instead, docker copies source code folder and cleans before build. This will prevent weird bugs from forgetting to clean up local build, more likely if local/image platform/os have differences.
Not using
.dockerignorebecause it would actually be a duplicate ofMakefileclean items.Tested with a local build from python3.10 and image build from python3.7 to ensure correctness.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.