bug fix: generate directory if path not exist in compile_mmap_model #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianhao2016
force-pushed
the
jianhaop
branch
from
9d08d28
to
4f4c6c2
Compare
hallogameboy
requested review from
weiliw-amz,
OctoberChang and
hallogameboy
weiliw-amz
reviewed
Feb 22, 2024
pecos/xmc/xlinear/model.py
Outdated
| @@ -144,6 +144,8 @@ def compile_mmap_model(cls, npz_folder, mmap_folder): | |||
| """ | |||
| import shutil | |||
|
|
|||
| if not path.exists(mmap_folder): | |||
There was a problem hiding this comment.
How about using os.makedirs(mmap_folder, exist_ok=True)?
https://docs.python.org/3/library/os.html#os.makedirs
There was a problem hiding this comment.
I was following the convention of previous changes, in that case should we change https://github.com/amzn/pecos/blob/mainline/pecos/xmc/xlinear/model.py#L98 as well?
There was a problem hiding this comment.
Updated both lines. Please check revision.
saving a XLinearModel.
jianhao2016
force-pushed
the
jianhaop
branch
from
4f4c6c2
to
c157f78
Compare
weiliw-amz
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
Generate directory if path not exist when saving a XLinearModel.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.