fix sparse gradient clipping for torch>=2.0 #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiong-zhang
requested review from
hallogameboy,
weiliw-amz,
OctoberChang and
rofuyu
jiong-zhang
force-pushed
the
torch-version-upgrade
branch
from
89fc95d
to
ed712db
Compare
jiong-zhang
force-pushed
the
torch-version-upgrade
branch
from
ed712db
to
c00ae42
Compare
hallogameboy
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
Update the torch dependency to >= 2.0. Since the gradient clipping no longer supports SparseCUDA backend, I include an old implementation of
torch.nn.clip_grad_norm_fromtorch==1.13.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.