-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow references without .value #721
Comments
Would love this as well. |
+1 This would be really helpful to synchronise our tokens between figma tokens and style dictionary. That way we can keep all our tokens as per W3C spec. |
+1 Would be really helpful for us too. |
+1 Would be really useful to stay aligned with Figma plugin and Style Dictionary output |
Closed via #746 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, for outputReferences to work, you need to define your reference using .value like:
If your reference doesn't include .value it won't work:
The design tokens working group first draft actually has the reference defined without .value
Would you be open to supporting references without .value to better align with the spec's working draft?
From what I can tell, we'd just need to modify around line 91 of https://github.com/amzn/style-dictionary/blob/main/lib/common/formatHelpers/createPropertyFormatter.js to maybe check if it's object and if the object has a value property, use that instead.
Would be happy to put in a PR if you think that's a good approach.
The text was updated successfully, but these errors were encountered: