Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump husky, change precommit hook, eslint scripts #1028

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

jorenbroekema
Copy link
Collaborator

  • No more npm test on precommit hook, takes a long time, we will let CI in Pull Requests do this verification step in the future. This also now blocks v4 branch from creating release commit, since tests are (knowingly) broken at the moment on this branch.
  • Update husky, use commitlint (it's installed but not used in any hooks to verify commits) and lint-staged properly for eslint/prettier on precommit.
  • Fix eslint scripts, both were doing "--fix" and one of the scripts was incorrectly using "--file" flag with no argument

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jorenbroekema jorenbroekema requested a review from a team as a code owner October 23, 2023 09:05
@jorenbroekema jorenbroekema merged commit 4d82091 into v4 Oct 23, 2023
0 of 2 checks passed
@jorenbroekema jorenbroekema deleted the fix-husky-eslint branch October 23, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant