Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Git clone and push #114

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

[WIP] Git clone and push #114

wants to merge 12 commits into from

Conversation

AlbertDeFusco
Copy link
Collaborator

@AlbertDeFusco AlbertDeFusco commented Mar 13, 2020

Once completed this will allow a user to run

  • ae5 project clone (clone the project locally)

  • ae5 git install-prepush (configure pre-push hook to automate tag inspection and metadata posting)

  • ae5 post revision-metadata (intended to be called by the pre-push hook above

@AlbertDeFusco
Copy link
Collaborator Author

Here is the procedure

  1. ae5 login
  2. ae5 project clone <project> <clone-directory>
  3. cd <clone-directroy>
  4. ae5 git install-prepush
  5. edit files
  6. git add <files>
  7. git commit
  8. git tag <tag> (optional)
  9. git push

@mcg1969
Copy link
Collaborator

mcg1969 commented May 7, 2020

@AlbertDeFusco is there a specific reason why ae5 project clone should not automatically call ae5 git install-prepush?

@AlbertDeFusco
Copy link
Collaborator Author

nope, but it will need to be run again when the token expires. I'll update the PR

@mcg1969
Copy link
Collaborator

mcg1969 commented May 7, 2020

How will the user experience token expiration? I wonder if there's a different hook we can offer that at least gives the user a heads-up.

@mcg1969
Copy link
Collaborator

mcg1969 commented May 7, 2020

Looking at your code it seems to me that install-prepush is independent of the token, and it's unclear why it would ever need to be run again. Hence it could be merged into clone and left there. But then we'd need, say, a refresh-token command or something. Is my understanding correct?

@AlbertDeFusco
Copy link
Collaborator Author

Yes, that would be better. git-push would then ask for the ae5 password on each call. We could store the offline token, which has a much longer (or infinite) expiration and make the exchange/refresh during git-push and it wouldn't ask for the password

@mcg1969
Copy link
Collaborator

mcg1969 commented May 15, 2020

Curious about the offline token. I'm wondering if we can generate those, either with ae5-tools or with some other process, for use in (say) CI/CD.

@AlbertDeFusco
Copy link
Collaborator Author

Curious about the offline token. I'm wondering if we can generate those, either with ae5-tools or with some other process, for use in (say) CI/CD.

exactly! I've made some progress on this and can report soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants