Skip the tests that only work with the testbed #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcg1969
force-pushed
the
skip-integration
branch
from
70b7212 to
e14bccf
Compare
mcg1969
force-pushed
the
skip-integration
branch
from
e14bccf to
9441d2a
Compare
mcg1969
changed the title
bkreider
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least one of the tests requires the existence of the testbed. But we'd like to be able to run as many tests as possible from within the conda build itself. To that end I'm marking testbed-dependent tests with
pytest.mark.testbed.The two tests are:
test_config.py/test_configuration: this test is designed to verify that the testbed contains a proper mix of kernel installation scenarios.test_config.py/test_install_kernelspec: this test will fail unless there is at least one kernel installed outside of the conda-build environment.Because the CI does exercise these tests fully, we are safe to skip them in the recipe build.
In order to test this, we've removed the
--no-testoption in thebuildstage.